Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT adjust test SPARK-26677: negated null-safe equality comparison #11522

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

Feng-Jiang28
Copy link
Collaborator

@Feng-Jiang28 Feng-Jiang28 commented Sep 27, 2024

This pr is for adjusting a test case that causes failure becuase it fetches the CPU version of Execution Plan instead of the GPU version.

Signed-off-by: fejiang <[email protected]>
@Feng-Jiang28 Feng-Jiang28 changed the title UT adjust test SPARK-26677: negated null-safe equality comparison UT adjust test SPARK-26677: negated null-safe equality comparison(WIP) Sep 27, 2024
@Feng-Jiang28 Feng-Jiang28 marked this pull request as draft September 27, 2024 09:35
Signed-off-by: fejiang <[email protected]>
@Feng-Jiang28 Feng-Jiang28 changed the base branch from branch-24.10 to branch-24.12 October 9, 2024 02:14
@sameerz sameerz added the test Only impacts tests label Oct 13, 2024
@Feng-Jiang28
Copy link
Collaborator Author

build

@Feng-Jiang28 Feng-Jiang28 marked this pull request as ready for review October 21, 2024 03:42
Copy link
Collaborator

@thirtiseven thirtiseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the status in RapidsTestSettings for this case?

@Feng-Jiang28
Copy link
Collaborator Author

build

thirtiseven
thirtiseven previously approved these changes Oct 23, 2024
@@ -19,9 +19,36 @@
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.rapids.suites

import com.nvidia.spark.rapids.GpuFilterExec

import org.apache.spark.sql.DataFrame
import org.apache.spark.sql.execution.datasources.parquet.ParquetQuerySuite
import org.apache.spark.sql.rapids.utils.RapidsSQLTestsBaseTrait

class RapidsParquetQuerySuite
extends ParquetQuerySuite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should the extends and with be in the same indent level?

Signed-off-by: fejiang <[email protected]>
@Feng-Jiang28
Copy link
Collaborator Author

build

3 similar comments
@Feng-Jiang28
Copy link
Collaborator Author

build

@Feng-Jiang28
Copy link
Collaborator Author

build

@Feng-Jiang28
Copy link
Collaborator Author

build

@Feng-Jiang28 Feng-Jiang28 changed the title UT adjust test SPARK-26677: negated null-safe equality comparison(WIP) UT adjust test SPARK-26677: negated null-safe equality comparison Oct 24, 2024
@Feng-Jiang28 Feng-Jiang28 merged commit db15a61 into NVIDIA:branch-24.12 Oct 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants